Open
Conversation
Contributor
|
I'll have a look this week - seems sensible. |
struan
requested changes
Oct 10, 2024
Member
struan
left a comment
struan
left a comment
There was a problem hiding this comment.
One actual bug and one only a bug if there is no content which does not happen outside of dev environment bugs.
Otherwise it all looks to make sense.
dracos
force-pushed
the
homepage-class-tidy-and-tweaks
branch
from
16710e4 to
63df0b0
Compare
Remove some unused bits.
ajparsons
force-pushed
the
homepage-class-tidy-and-tweaks
branch
from
63df0b0 to
674b519
Compare
Contributor
|
I've fixed the rebase issue - I think it was unhappy about the popular search item being removed from homepage in master, while that was all being removed and renamed here. I can just merge this if no reasons not to. |
dracos
force-pushed
the
master
branch
2 times, most recently
from
eaabd03 to
986c3f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know who should review something like this currently :) The only actual change should be displaying Welsh votes at all, moving Scottish votes underneath Scottish debates, and including Commons/Lords on UK (fixes #1832) on their homepages. The rest is just trying to tidy all these homepages to use the same homepage base class, which seemed sensible whilst I was there, they're mostly the same now (more could probably be done, combining templates and whatnot, but seemed enough for now).